扩展 key 的支持范围 #463
Merged
扩展 key 的支持范围 #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 39.64% 40.00% +0.35%
==========================================
Files 7 7
Lines 454 455 +1
Branches 95 98 +3
==========================================
+ Hits 180 182 +2
+ Misses 272 271 -1
Partials 2 2
Continue to review full report at Codecov.
|
nighca
reviewed
Jul 31, 2020
src/utils.ts
Outdated
| @@ -53,7 +53,7 @@ export function setLocalFileInfo(localKey: string, info: LocalInfo) { | |||
| } | |||
| } | |||
|
|
|||
| export function createLocalKey(name: string, key: string, size: number): string { | |||
| export function createLocalKey(name: string, key: string | null, size: number): string { | |||
lzfee0227
reviewed
Jul 31, 2020
nighca
reviewed
Jul 31, 2020
src/utils.ts
Outdated
| export function createLocalKey(name: string, key: string | null, size: number): string { | ||
| return `qiniu_js_sdk_upload_file_name_${name}_key_${key}_size_${size}` | ||
| export function createLocalKey(name: string, key: string | null | undefined, size: number): string { | ||
| return `qiniu_js_sdk_upload_file_name_${name}_key_${key == null ? '' : key}_size_${size}` |
added 4 commits
July 31, 2020 18:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null或者undefined时，参数设为~，则自动采用 hash 设为文件资源名，