Skip to content

fix: type define of compress.ts #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2021
Merged

fix: type define of compress.ts #498

merged 4 commits into from
Apr 16, 2021

Conversation

hovenjay
Copy link
Contributor

@hovenjay hovenjay commented Apr 16, 2021

fix #497

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #498 (a942151) into master (2d474dc) will not change coverage.
The diff coverage is n/a.

❗ Current head a942151 differs from pull request most recent head 81aa67b. Consider uploading reports for the commit 81aa67b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   40.00%   40.00%           
=======================================
  Files           7        7           
  Lines         455      455           
  Branches       99       99           
=======================================
  Hits          182      182           
  Misses        271      271           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d474dc...81aa67b. Read the comment docs.

yinxulai
yinxulai previously approved these changes Apr 16, 2021
@yinxulai
Copy link
Collaborator

仔细看了一下,是类型写的不对,确实可能返回 File

change type.
@hovenjay hovenjay requested a review from yinxulai April 16, 2021 08:26
@yinxulai yinxulai changed the title Update README.md fix CompressResult type error Apr 16, 2021
@hovenjay hovenjay changed the title fix CompressResult type error fix: type define of compress.ts Apr 16, 2021
@yinxulai yinxulai merged commit 4a1da8c into qiniu:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document chore
3 participants