[BUG] 修复 initBeforeUploadChunks 错误未中断的行为 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
=======================================
Coverage 42.21% 42.21%
=======================================
Files 9 9
Lines 514 514
Branches 113 113
=======================================
Hits 217 217
Misses 285 285
Partials 12 12 Continue to review full report at Codecov.
|
lzfee0227
reviewed
Apr 21, 2021
yinxulai
commented
Apr 21, 2021
| const errorMessage = 'chunkSize must be a positive integer.' | ||
| this.logger.error(errorMessage) | ||
| throw new Error(errorMessage) | ||
| throw new Error('chunkSize must be a positive integer.') |
There was a problem hiding this comment.
log 输出应秉承，谁消费、谁输出，例如这里:
不应该一边产生了一个副作用（输出日志），又 throw Error，很容易导致外面重复输出
There was a problem hiding this comment.
如上个 pr 所说的
putFile 方法也应该设计成这样，而不应该改定位
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.