Skip to content

修复 eslint & 为 QiniuRequestError 添加 data 字段 & 为 chunk 添加 fromCache 字段 #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2021

Conversation

yinxulai
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #511 (bb62ca8) into master (a39495b) will decrease coverage by 0.11%.
The diff coverage is 70.00%.

❗ Current head bb62ca8 differs from pull request most recent head aca9fb8. Consider uploading reports for the commit aca9fb8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   72.36%   72.24%   -0.12%     
==========================================
  Files          20       20              
  Lines        1071     1081      +10     
  Branches      206      208       +2     
==========================================
+ Hits          775      781       +6     
- Misses        296      300       +4     
Impacted Files Coverage Δ
src/api/index.mock.ts 94.87% <ø> (ø)
src/utils/compress.ts 16.98% <ø> (ø)
src/utils/helper.ts 52.90% <0.00%> (-0.94%) ⬇️
src/upload/resume.ts 93.06% <85.71%> (-0.62%) ⬇️
src/errors/index.ts 100.00% <100.00%> (ø)
src/upload/base.ts 82.56% <100.00%> (ø)
src/upload/hosts.ts 100.00% <100.00%> (ø)
src/upload/index.ts 93.33% <100.00%> (+0.22%) ⬆️
src/utils/config.ts 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39495b...aca9fb8. Read the comment docs.

@yinxulai yinxulai changed the title 修复 eslint & 为 QiniuRequestError 添加 data 字段 修复 eslint & 为 QiniuRequestError 添加 data 字段 & 为 chunk 添加 isLocalCached 字段 May 21, 2021
/**
* @description 发生错误时服务端返回的错误信息,如果返回不是一个合法的 json、则该字段为 undefined
*/
public data: any = undefined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public data?: any

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any 和 unknown 哪个好啊

@lzfee0227
Copy link
Collaborator

readme 没更新啊

@yinxulai yinxulai force-pushed the master branch 2 times, most recently from 0a77f3d to 7781a73 Compare May 21, 2021 09:10
Copy link
Collaborator

@lzfee0227 lzfee0227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinxulai yinxulai force-pushed the master branch 2 times, most recently from bb62ca8 to aca9fb8 Compare May 21, 2021 10:19
Copy link
Collaborator

@lzfee0227 lzfee0227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
剩下一个问题:cache 的数据不应该一开始就全部挂载上
应该处理到哪个 chunk 才塞哪个

@lzfee0227 lzfee0227 merged commit 71b1482 into qiniu:master May 21, 2021
@yinxulai yinxulai changed the title 修复 eslint & 为 QiniuRequestError 添加 data 字段 & 为 chunk 添加 isLocalCached 字段 修复 eslint & 为 QiniuRequestError 添加 data 字段 & 为 chunk 添加 fromCache 字段 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants