-
Notifications
You must be signed in to change notification settings - Fork 516
修复 eslint & 为 QiniuRequestError 添加 data 字段 & 为 chunk 添加 fromCache 字段 #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
==========================================
- Coverage 72.36% 72.24% -0.12%
==========================================
Files 20 20
Lines 1071 1081 +10
Branches 206 208 +2
==========================================
+ Hits 775 781 +6
- Misses 296 300 +4
Continue to review full report at Codecov.
|
src/errors/index.ts
Outdated
/** | ||
* @description 发生错误时服务端返回的错误信息,如果返回不是一个合法的 json、则该字段为 undefined | ||
*/ | ||
public data: any = undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public data?: any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any 和 unknown 哪个好啊
readme 没更新啊 |
0a77f3d
to
7781a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bb62ca8
to
aca9fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
剩下一个问题:cache 的数据不应该一开始就全部挂载上
应该处理到哪个 chunk 才塞哪个
No description provided.