[KODO-15365] 修复偶发性无法停止任务的 BUG #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2788
previously approved these changes
Jun 21, 2022
| (chunkInfo: ChunkInfo) => this.uploadChunk(chunkInfo), | ||
| async (chunkInfo: ChunkInfo) => { | ||
| if (this.aborted) return | ||
| await this.uploadChunk(chunkInfo) |
There was a problem hiding this comment.
有作用，当 catch 的时候需要抛错误给 Pool
lzfee0227
reviewed
Jun 21, 2022
lzfee0227
reviewed
Jun 21, 2022
lzfee0227
reviewed
Jun 21, 2022
lzfee0227
reviewed
Jun 21, 2022
Comment on lines
+96
to
+98
| if (this.aborted) { | ||
| pool.abort() | ||
| throw new Error('pool is aborted') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
abort可能失败的问题 #539原因分析
pool中未执行到的uploadChuck