-
Notifications
You must be signed in to change notification settings - Fork 516
将 CI 从 trivas 切换为 github actions #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
node-version: 12 | ||
- run: npm install | ||
- run: npm run test | ||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev 需要 build 吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多检查检查,没什么问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIP: 打 tag 也是可以自动化的:package.json 中的 version 变化则自动用当前 version 打一个 tag,这个 tag 在后续人肉发 release 时可以直接使用;这样从 package.json 中的 version,到 tag 名,再到对应的 release 里去 publish version,就都串起来了
.github/workflows/npm-publish.yml
Outdated
|
||
on: | ||
release: | ||
types: [created] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我之前在 formstate-x 搞的时候用的是 published
,我去看了下 published
跟 created
的区别,有可能 published
是更贴切的?
The action that was performed. Can be one of:
- published: a release, pre-release, or draft of a release is published
- created: a draft is saved, or a release or pre-release is published without previously being saved as a draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有道理,看起来 published
更接近完成的状态
嗯嗯,kodo-base 我也是这样搞的,可以后面优化一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧘
TODO