Skip to content

将 CI 从 trivas 切换为 github actions #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Conversation

yinxulai
Copy link
Collaborator

@yinxulai yinxulai commented Jun 22, 2022

TODO

@yinxulai yinxulai mentioned this pull request Jun 22, 2022
node-version: 12
- run: npm install
- run: npm run test
build:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev 需要 build 吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多检查检查,没什么问题

huangbinjie
huangbinjie previously approved these changes Jun 22, 2022
Copy link

@huangbinjie huangbinjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nighca nighca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIP: 打 tag 也是可以自动化的:package.json 中的 version 变化则自动用当前 version 打一个 tag,这个 tag 在后续人肉发 release 时可以直接使用;这样从 package.json 中的 version,到 tag 名,再到对应的 release 里去 publish version,就都串起来了


on:
release:
types: [created]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我之前在 formstate-x 搞的时候用的是 published,我去看了下 publishedcreated 的区别,有可能 published 是更贴切的?

The action that was performed. Can be one of:

  • published: a release, pre-release, or draft of a release is published
  • created: a draft is saved, or a release or pre-release is published without previously being saved as a draft

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有道理,看起来 published 更接近完成的状态

@yinxulai
Copy link
Collaborator Author

NIP: 打 tag 也是可以自动化的:package.json 中的 version 变化则自动用当前 version 打一个 tag,这个 tag 在后续人肉发 release 时可以直接使用;这样从 package.json 中的 version,到 tag 名,再到对应的 release 里去 publish version,就都串起来了

嗯嗯,kodo-base 我也是这样搞的,可以后面优化一下

Copy link
Contributor

@nighca nighca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧘

@yinxulai yinxulai merged commit 5c7686f into qiniu:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants