retry when upload expire and fix event, cors api and fix tests #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachue
approved these changes
Sep 16, 2022
lihsai0
force-pushed
the
features/retry-when-upload-expire
branch
2 times, most recently
from
1fc9e52 to
447252c
Compare
bachue
approved these changes
Sep 23, 2022
- read response body error first - add rpqId property - always try to delete rtc app after tests
lihsai0
force-pushed
the
features/retry-when-upload-expire
branch
from
447252c to
3c23f33
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 84.53% 84.56% +0.02%
==========================================
Files 16 16
Lines 1410 1445 +35
Branches 320 333 +13
==========================================
+ Hits 1192 1222 +30
- Misses 218 223 +5
|
bachue
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.