resumableio: use mkfile #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url.append("params/%s" % urlsafe_b64encode(extra.callback_params)) | ||
| if extra.params: | ||
| for k, v in extra.params.iteritems(): | ||
| url.append("%s/%s" % (k, urlsafe_b64encode(v))) |
There was a problem hiding this comment.
此处k直接拼接入url，如果用户提供的自定义变量名包含url-unsafe的字符会发生什么？
There was a problem hiding this comment.
自定义变量名的命名用户可控，可以规避
服务端也没有进行相应的encode措施
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.