Fix appender-ref resolution in complex appenders inside SiftingAppender #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project we had a custom appender that implements AppenderAttachable interface which worked inside a SiftingAppender prior to Logback 1.3.
In Logback 1.5.18 it's only working in root scope as
But when put inside SiftingAppender, the appender-ref behaves as an ImplicitModel and is ignored.
This PR fixes the issue by allowing appender-ref inside appender/sift/appender/appender-ref . Direct usage of appender-ref in sift is still prohibited (as it has no sense)