-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[feat] Adding camvid segmentation multiclass as an example #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Adding camvid segmentation multiclass as an example #922
Conversation
Hi @TimbusCalin, thanks a lot for your contribution! Looks great overall and it's pretty close to being merged, here are just a few minor comments:
maybe somewhere else
|
I think the OUT_CLASSES should be equal to length of CLASSES. Since the background(unlabelled) classes is already included in the CLASSES list. OUT_CLASSES = len(train_dataset.CLASSES) + 1 This should be in case when no class is specified. OUT_CLASSES = len(train_dataset.CLASSES) The |
Oh sorry, I missed your last commit. Apologies |
@abdksyed no issue, another pair of (good!) eyes is always necessary and welcome! |
@qubvel I guess the dillema is solved. We can integrate if you have no other remarks. |
Thanks for your contribution! |
@abdksyed Do you have an example for how we can compute the class-wise miou? |
@sajeedmehrab |
Would appreciate if you contribute torch metrics example 😊 |
Fixes: #911