Skip to content

fix: more descriptive error messages #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2023
Merged

fix: more descriptive error messages #49

merged 5 commits into from
Nov 29, 2023

Conversation

jerrinot
Copy link
Contributor

also: fix a possible panic when public keys are too long

I believe the original message was misleading:
A private key is just one of possible root causes
when a private key is not matching a public key.
It could be also a bad public key.
@amunra amunra marked this pull request as ready for review November 29, 2023 09:50
@amunra amunra self-requested a review November 29, 2023 09:50
Copy link
Collaborator

@amunra amunra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests look great to me!

@amunra amunra merged commit ea926d5 into main Nov 29, 2023
@amunra amunra deleted the jh_better_errors branch November 29, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants