-
Notifications
You must be signed in to change notification settings - Fork 10
BREAKING: New ILP/HTTP and Sender.from_conf
API
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For the related Rust/C client changes, see questdb/c-questdb-client#50 and questdb/c-questdb-client#54 |
feat: support arrow large utf8 string format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Leaving it out completely was not an option due to a TypeError.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented in a few areas.
Please @goodroot anywhere you'd like me to pickup next week.
Docs look OK to me on surface, prefer to unblock the API changes.
Overview
Sender.from_conf
andSender.from_env
APIs which will simplify construction of the sender.at=
argument in.row()
and.dataframe()
methods mandatory.Tasks
c-questdb-client
code.at=..
KW parameter required inrow
anddataframe
API, new "ServerNow" for oldat=None
behaviour.Sender::from_conf('...', **kwargs)
.with sender.transaction()
to temporarily disable auto-flushing.sender.flush(buffer, transactional=True)
.with sender:
block: Final flush should still happen.sender.transaction()
.init_buf_size
andmax_buf_size
params._FLUSH_FMT
for HTTP.from_conf
example and register it with the manifest filetxn.commit()
multiple times.sender.flush()
from within atxn
block.Closes #51.
Closes #62.