Respond to upcoming changes in glue::glue_collapse()
#310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
changed the title
glue::glue_collapse()
3 tasks
|
The CI failure doesn't appear to be associated with what's going on in this PR. |
romainfrancois
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next version of glue,
glue::glue_collapse()will never returncharacter()but instead will return""for empty inputs. For more detail see tidyverse/glue#295.This makes the necessary change inside cpp11 and places 2 temporary skips in the tests so cpp11 can be released before glue. Interestingly, this actually makes the tests match their existing descriptions.
I won't release glue for at least two weeks (so: March 31) and it will likely be later.