Skip to content

Make more of the API internal #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 26, 2024
Merged

Make more of the API internal #50

merged 7 commits into from
Aug 26, 2024

Conversation

lukebakken
Copy link
Contributor

  • Make QueueSpec internal

@lukebakken
Make more of the API internal
4127cd2 
* Make `QueueSpec` internal
@lukebakken lukebakken added this to the 0.1.0 milestone Aug 26, 2024
@lukebakken lukebakken self-assigned this Aug 26, 2024
Gsantomaggio
Gsantomaggio previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! you are right! that should be internals

@lukebakken lukebakken marked this pull request as ready for review August 26, 2024 15:23
@lukebakken lukebakken merged commit 4a95106 into main Aug 26, 2024
1 check passed
@lukebakken lukebakken deleted the lukebakken/internal-ize-classes branch August 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gsantomaggio Gsantomaggio Gsantomaggio left review comments

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @Gsantomaggio