Enable verbose logging of when a test starts and stops #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, now it works without problems :) |
|
Of course. I've been able to reproduce a different hang locally, where all of the tests run but the test host does not exit as expected 🤔 |
|
I commented-out the connection recovery test suite and haven't been able to repro, so 🙏 ... that's where I should look... |
lukebakken
force-pushed
the
rabbitmq-amqp-dotnet-client-87
branch
from
d2a5800 to
3a487b4
Compare
…est(s) freeze in GHA * Update deps * Modify `ConnectionRecoveryTests` to use `IntegrationTest` base class `_containerId` property. * Generate dotnet test diag logs on GH and upload on failure * Comment out `ConnectionRecoveryTests` 🤷 * Don't log an expected exception. * Re-enable `ConnectionRecoveryTests` one at a time. * Re-enable a test * Re-enable two more `ConnectionRecoveryTests` * Re-enable yet two more `ConnectionRecoveryTests` * Re-enable two more `ConnectionRecoveryTests` * Re-enable two more `ConnectionRecoveryTests` * No more skipped tests * Refactor how a couple links are created and the use of TaskCompletionSource * Remove the rest of the use of `Debug.Assert`
lukebakken
force-pushed
the
rabbitmq-amqp-dotnet-client-87
branch
from
b160a1f to
472f7ef
Compare
|
@Gsantomaggio there isn't anything earth-shattering here. I don't know why the test suite has run successfully every time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully it will show which test(s) freeze in GHA
Fixes #87