Skip to content

Address GHA test flakes #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Address GHA test flakes #97

merged 1 commit into from
Nov 22, 2024

Conversation

lukebakken
Copy link
Contributor

  • Start by addressing a potential NullReferenceException

@lukebakken lukebakken self-assigned this Nov 21, 2024
@lukebakken lukebakken added this to the 0.1.0-beta.1 milestone Nov 21, 2024
* Start by addressing a potential `NullReferenceException`
* Try to address `TimeoutException` by using `WhenTcsCompetes`
* Standardize in tests on using `WhenTcsCompletes`
* Move all of `SystemUtils` into `IntegrationTest.Static.cs`
* Consolidate creation of TaskCompletionSource objects to ensure correct TaskCreationOptions are used.
* Bump RMQ to 4.0.4 on Windows
@lukebakken lukebakken force-pushed the lukebakken/test-flakes branch from a89cbd1 to 6bab211 Compare November 22, 2024 18:23
@lukebakken lukebakken marked this pull request as ready for review November 22, 2024 18:26
@lukebakken lukebakken merged commit f57ae22 into main Nov 22, 2024
0 of 2 checks passed
@lukebakken lukebakken deleted the lukebakken/test-flakes branch November 22, 2024 18:29
@lukebakken lukebakken modified the milestones: 0.2.0-beta.0, 0.1.0 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant