Skip to content

Add support for multiple Uris #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

lukebakken
Copy link
Contributor

Part of #95

  • Start by adding the bare minimum to support a list of Uris, and randomly selecting from that list when an Address is needed

@lukebakken lukebakken self-assigned this Nov 25, 2024
@lukebakken lukebakken added this to the 0.2.0-beta.0 milestone Nov 25, 2024
@lukebakken lukebakken marked this pull request as ready for review November 27, 2024 15:47
@lukebakken lukebakken marked this pull request as draft November 27, 2024 15:48
@lukebakken
Copy link
Contributor Author

One last item: ConnectionSettingsViaUris needs to override Equals to take all Uris into account.

@Gsantomaggio
Copy link
Member

It looks good to me.
What if we leave only Uris instead of two configurations: Uris and Uri ?

@lukebakken lukebakken force-pushed the rabbitmq-amqp-dotnet-client-95-2 branch from 0c47298 to 1652cf5 Compare December 3, 2024 00:33
@lukebakken lukebakken marked this pull request as ready for review December 3, 2024 00:33
Part of #95

* Start by adding the bare minimum to support a list of Uris, and randomly selecting from that list when an Address is needed
* Ensure all vhosts passed in a list of Uris match
* Rework `ConnectionSettings` ctors to allow other settings when Uri or Uris are used.
* Add `IUriSelector`
* Use `ConnectionSettingsViaUris` when specifying a set of `Uri` instances to which to connect.
* Wrap up equality comparison.
* Rename to `ClusterConnectionSettings`
* Validate that scheme is amqp or amqps
@lukebakken lukebakken force-pushed the rabbitmq-amqp-dotnet-client-95-2 branch from 1652cf5 to 725423a Compare December 3, 2024 00:44
@lukebakken lukebakken merged commit 37d086a into main Dec 3, 2024
2 checks passed
@lukebakken lukebakken deleted the rabbitmq-amqp-dotnet-client-95-2 branch December 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants