This repository was archived by the owner on Nov 18, 2020. It is now read-only.
Adapt rabbitmq-diagnostics memory_breakdown to server master #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically to rabbitmq/rabbitmq-server#1404. Closes #228. [#153217000]
hairyhum
suggested changes
Nov 28, 2017
| # See https://github.com/rabbitmq/rabbitmq-server/pull/1404. | ||
| totals = Keyword.get(num_pairs, :total) | ||
| pairs = Keyword.delete(num_pairs, :total) | ||
| total = Keyword.get(totals, strategy) || |
There was a problem hiding this comment.
The new memory reporting API reports strategy but does not take it to account when reporting the breakdown. For example if erlang strategy is configured, preallocated memory will still be reported.
To create a reasonable percentage breakdown we should not select total using strategy. Instead maximal value of three totals can be used, or use rss like HTTP API.
hairyhum
approved these changes
Nov 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically to rabbitmq/rabbitmq-server#1404.
Closes #228.
[#153217000]