This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Augment closed connection log entries #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so for abrupt closure cases requires augmenting
exceptions thrown, including for socket errors ({inet_error, ...} and such).
That is a more risky change which may or may not be worth the improvement:
* Socket error formatting happens in multiple places
* Plugins can use/depend on socket errors being primarily 2-tuples
dcorbacho
approved these changes
May 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some "connection closed" cases. In others the changes required are too risky for
3.6.x.