Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

fix supervisor2's state for get {badrecord,state} error when release upgrade #230

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Conversation

feng19
Copy link
Contributor

@feng19 feng19 commented Oct 13, 2017

supervisor's state change from otp-18 and add a field, but supervisor2 didn't.
So, when i do release upgrade it will print a error msg:

<0.1153.0> reason: {'EXIT',
                       {{badrecord,state},
                        [{supervisor,get_callback_module,1,
                             [{file,'supervisor.erl'},{line,266}]},
                         {release_handler_1,get_supervisor_module,1,
                             [{file,'release_handler_1.erl'},{line,684}]},
                         {release_handler_1,get_master_procs,3,
                             [{file,'release_handler_1.erl'},{line,605}]},
                         {lists,foldl,3,[{file,'lists.erl'},{line,1262}]},
                         {release_handler_1,eval,2,
                             [{file,'release_handler_1.erl'},{line,375}]},
                         {lists,foldl,3,[{file,'lists.erl'},{line,1262}]},
                         {release_handler_1,eval_script,5,
                             [{file,'release_handler_1.erl'},{line,102}]},
                         {release_handler,eval_script,5,
                             [{file,'release_handler.erl'},{line,368}]}]}}
release_handler: cannot find top supervisor for application amqp_client

For fix this, i just add a field in new otp version.

@pivotal-issuemaster
Copy link

@feng19 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@feng19 Thank you for signing the Contributor License Agreement!

@michaelklishin
Copy link
Contributor

@feng19 thank you. May I ask you to re-submit this against the stable branch?

@michaelklishin michaelklishin added this to the 3.6.13 milestone Oct 13, 2017
@feng19 feng19 changed the base branch from master to stable October 13, 2017 15:34
@feng19
Copy link
Contributor Author

feng19 commented Oct 13, 2017

OK! Have a nice weekend.

Copy link
Contributor

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully run all 3 (common, Erlang client, server) test suites with this on R16B03, 17.5 and 19.3.6.

OTP 17 supervisor state and OTP 19 one indeed differ as advertised.

@michaelklishin
Copy link
Contributor

michaelklishin commented Oct 15, 2017

Note: conditional compilation won't be used in master as OTP 19.2 (and soon 19.3) is the minimum supported version.

@michaelklishin michaelklishin merged commit 0d40c7c into rabbitmq:stable Oct 15, 2017
michaelklishin added a commit that referenced this pull request Oct 16, 2017
@feng19 feng19 deleted the new_sup2_state branch October 16, 2017 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants