This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Quorum queues #274
Merged
Quorum queues #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
quorum-queue
branch
from
10a16f8 to
aec9158
Compare
With the quorum queue code, RabbitMQ probably still works with Erlang 20.x, but it is not thoroughly tested. Thus, bump the requirement to Erlang 21.0.
Rate metrics for monitoring of high connection churn scenarios [#160943831]
…down [#160943831]
It has been reported that in order to use the Erlang client, the Erlang/OTP source must be available. This is due to one include file that rabbit_net required. This dependency has been removed. Instead of calling is_record(sslsocket) the macro ?IS_SSL will now perform the same test manually (check that it is a tuple, that the size is correct and that the first element equals sslsocket). The tuple has not changed in a very long time so doing this manually is at least as safe as including this private header file (it could be removed or moved at any time). Once Erlang/OTP 22 gets out and we know how sockets will be represented with the NIF implementation, we could revise this and check whether the socket is one that gen_tcp accepts (currently it's a port, but this will probably change when a NIF is used).
|
It looks like some changes are unrelated to the quorum queue, like |
|
QQ branches had |
|
It would be nice to see the actual changes without noise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: rabbitmq/rabbitmq-server#1706