Skip to content

Find app schema either in deps/App/priv or priv/ #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2017
Merged

Find app schema either in deps/App/priv or priv/ #9

merged 2 commits into from
Jun 7, 2017

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Jun 6, 2017 •
edited
Loading

Try to find app-specific schema in deps/App/priv, otherwise try deps/../priv

Fixes #8 (repro steps in that issue)

@lukebakken lukebakken self-assigned this Jun 6, 2017
@lukebakken lukebakken changed the title WIP: Resolve issue #8 Find app schema either in deps/App/priv or priv/ Jun 7, 2017
@lukebakken lukebakken requested a review from hairyhum June 7, 2017 15:40
@hairyhum
Copy link
Contributor

hairyhum commented Jun 7, 2017

Can we use code:priv_dir instead?

@lukebakken
Copy link
Contributor Author

I tried code:priv_dir(App) but got {error, bad_name}. I'm assuming this is because the application module isn't loaded at that time.

@hairyhum hairyhum merged commit ceb4409 into master Jun 7, 2017
@lukebakken lukebakken deleted the rabbitmq-ct-helpers-8 branch June 7, 2017 17:01
@lukebakken
Copy link
Contributor Author

Thanks for the review @hairyhum

This was referenced Jun 14, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairyhum hairyhum Awaiting requested review from hairyhum

Assignees

@lukebakken lukebakken

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @hairyhum