AutorecoveringModel.IsClosed should return true if model is unusable

[onematchfox]

Proposed Changes

As per the description of IsClosed on IModel.cs, this property should

return[s] true if the model is no longer in a state where it can be used

At present this returns false if the _delegate has been disposed of which, I would say indicates that the model "is no longer in a state where it can be used".

Fixes (copy-paste?) regression introduced as part of 54f7840 by aligning the behaviour of IsClosed with the underlying implementation that would have been called were the delegate not disposed of.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

If approved then the same change will need to be applied to main although the commit in this PR can't be simply cherry-picked across. Let me know if you'd like me to submit a separate PR for this or if one of the maintainers will handle this.

[michaelklishin]

Thank you!

[lukebakken]

If approved then the same change will need to be applied to main although the commit in this PR can't be simply cherry-picked across. Let me know if you'd like me to submit a separate PR for this or if one of the maintainers will handle this.

@onematchfox sure, we'd appreciate a separate PR for main. Thanks!