Fix incorrect unbind queue after recovery connection

[MIVerTFT]

Proposed Changes

It seems to me that there is an error in the connection recovery code. The error is that when restoring a binding between the exchange and the server-named queue, there is a change in the "RecordedQueueBinding.Destination" that affects the hash, which makes it impossible to delete records from the _recordedBindings dictionary, since the dictionary does not re-calculate the hash value. This situation eventually leads to the fact that all subsequent connection shutdown will not be correctly restored.

The written test demonstrates this problem.

Types of Changes

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

[pivotal-cla]

@MIVerTFT Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@MIVerTFT Thank you for signing the Contributor License Agreement!

[michaelklishin]

@MIVerTFT thank you. Can you please submit the same change against main?

[MIVerTFT]

@MIVerTFT thank you. Can you please submit the same change against main?

@michaelklishin

main doesn't have this bug. Apparently, when they redid RecordedBinding from a class to a structure, they fixed it.

[michaelklishin]

Yup, I've just found out just as much. Thank you for confirming @MIVerTFT.