Skip to content

thread-safe Random generation #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2022
Merged

thread-safe Random generation #1207

merged 1 commit into from
May 14, 2022

Conversation

amiru3f
Copy link

@amiru3f amiru3f commented May 14, 2022

Proposed Changes

As you may know, using Random.Shared is new-generation approach in net6 or upper, It's thread safe and optimized. So I replaced old _rnd.Next() with Shared Random if and only if the platform is net6 or later.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

@michaelklishin michaelklishin added this to the 7.0.0 milestone May 14, 2022
@michaelklishin michaelklishin merged commit 35e5cdc into rabbitmq:main May 14, 2022
@michaelklishin
Copy link
Contributor

Thank you!

@michaelklishin
Copy link
Contributor

@amiru3f for random endpoint selection within connection, I don't think we absolutely need to use a thread safe version but nothing wrong with using a modern .NET 6 option when we can 👍

michaelklishin added a commit that referenced this pull request May 14, 2022
michaelklishin added a commit that referenced this pull request May 15, 2022
(cherry picked from commit 1b94cb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants