Skip to content

Delete recorded consumers when autorecovering model is disposed #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

Delete recorded consumers when autorecovering model is disposed #1317

merged 1 commit into from
Mar 22, 2023

Conversation

lukebakken
Copy link
Collaborator

Fixes #1302

@lukebakken lukebakken self-assigned this Mar 20, 2023
@lukebakken lukebakken added this to the 6.5.0 milestone Mar 20, 2023
@lukebakken lukebakken mentioned this pull request Mar 20, 2023
Closed
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1302 branch 6 times, most recently from 8d80556 to 8928e0a Compare March 20, 2023 23:09
Zerpet
Zerpet reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable, although CI/Actions seems unhappy.

@lukebakken
Copy link
Collaborator Author

Hmm I appear to have broken something 😉

@lukebakken lukebakken marked this pull request as draft March 21, 2023 14:01
@lukebakken lukebakken removed this from the 6.5.0 milestone Mar 21, 2023
@lukebakken lukebakken changed the title Delete recorded consumers when autorecovering model is disposed Delete recorded consumers when autorecovering model is closed Mar 21, 2023
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1302 branch from cfcec5d to fdd0fa4 Compare March 21, 2023 15:09
@lukebakken lukebakken changed the title Delete recorded consumers when autorecovering model is closed Delete recorded consumers when autorecovering model is disposed Mar 21, 2023
@lukebakken lukebakken marked this pull request as ready for review March 21, 2023 15:21
@lukebakken lukebakken requested a review from Zerpet March 21, 2023 15:21
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1302 branch from fdd0fa4 to 63b0a82 Compare March 22, 2023 15:05
@lukebakken
Delete recorded consumers when autorecovering model is disposed
bda44c9 
Fixes #1302

Update dependencies

Ensure RecordedConsumer has a ConsumerTag
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1302 branch from 63b0a82 to bda44c9 Compare March 22, 2023 15:11
@lukebakken lukebakken merged commit 8cd6ffb into 6.x Mar 22, 2023
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1302 branch March 22, 2023 15:57
@Zerpet
Copy link
Member

Zerpet commented Mar 22, 2023

@lukebakken should we port this to main?

@lukebakken
Copy link
Collaborator Author

Yep, I'm getting it right now. I can't even cherry-pick anymore since main is so different. Good incentive to get 7.0 out!

lukebakken added a commit that referenced this pull request Mar 22, 2023
@lukebakken
Port #1317 to main
36233ad 
Fixes #1302

References #1317
@lukebakken lukebakken mentioned this pull request Mar 22, 2023
Merged
lukebakken added a commit that referenced this pull request Mar 23, 2023
@lukebakken
Merge pull request #1323 from rabbitmq/rabbitmq-dotnet-client-1302-main
2b06f48 
Port #1317 to main
@tiggerite tiggerite mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet left review comments

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @Zerpet