-
Notifications
You must be signed in to change notification settings - Fork 606
Async flow control #1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Async flow control #1681
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
29801be
Basic implementation of AsyncManualResetEvent
danielmarbach cbd994b
Adjust channel to use new async primitive
danielmarbach d769508
Use ManualResetValueTaskSourceCore for more efficiency
danielmarbach 13ec023
Propagate value task
danielmarbach b52c3d1
Remove now unnecessary link
danielmarbach 382c0e7
Volatile.Read and Write
danielmarbach ddbf555
Minor formatting change.
lukebakken e206659
Use IsSet
danielmarbach 393dacf
Validate token
danielmarbach ea6fdcc
Use default
danielmarbach a15c1f8
Rename to fix conflict with event.
lukebakken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
155 changes: 155 additions & 0 deletions
155
projects/RabbitMQ.Client/client/impl/AsyncManualResetEvent.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,155 @@ | ||
// This source code is dual-licensed under the Apache License, version | ||
// 2.0, and the Mozilla Public License, version 2.0. | ||
// | ||
// The APL v2.0: | ||
// | ||
//--------------------------------------------------------------------------- | ||
// Copyright (c) 2007-2024 Broadcom. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
//--------------------------------------------------------------------------- | ||
// | ||
// The MPL v2.0: | ||
// | ||
//--------------------------------------------------------------------------- | ||
// This Source Code Form is subject to the terms of the Mozilla Public | ||
// License, v. 2.0. If a copy of the MPL was not distributed with this | ||
// file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
// | ||
// Copyright (c) 2007-2024 Broadcom. All Rights Reserved. | ||
//--------------------------------------------------------------------------- | ||
|
||
using System; | ||
using System.Diagnostics.CodeAnalysis; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using System.Threading.Tasks.Sources; | ||
|
||
namespace RabbitMQ.Client.client.impl | ||
{ | ||
sealed class AsyncManualResetEvent : IValueTaskSource | ||
{ | ||
private ManualResetValueTaskSourceCore<bool> _valueTaskSource; | ||
private bool _isSet; | ||
|
||
public AsyncManualResetEvent(bool initialState = false) | ||
{ | ||
_isSet = initialState; | ||
_valueTaskSource.Reset(); | ||
if (initialState) | ||
{ | ||
_valueTaskSource.SetResult(true); | ||
} | ||
} | ||
|
||
public bool IsSet => Volatile.Read(ref _isSet); | ||
|
||
public async ValueTask WaitAsync(CancellationToken cancellationToken) | ||
{ | ||
if (IsSet) | ||
{ | ||
return; | ||
} | ||
|
||
cancellationToken.ThrowIfCancellationRequested(); | ||
|
||
CancellationTokenRegistration tokenRegistration = | ||
#if NET6_0_OR_GREATER | ||
cancellationToken.UnsafeRegister( | ||
static state => | ||
{ | ||
var (source, token) = ((ManualResetValueTaskSourceCore<bool>, CancellationToken))state!; | ||
source.SetException(new OperationCanceledException(token)); | ||
}, (_valueTaskSource, cancellationToken)); | ||
#else | ||
cancellationToken.Register( | ||
static state => | ||
{ | ||
var (source, token) = ((ManualResetValueTaskSourceCore<bool>, CancellationToken))state!; | ||
source.SetException(new OperationCanceledException(token)); | ||
}, | ||
state: (_valueTaskSource, cancellationToken), useSynchronizationContext: false); | ||
#endif | ||
try | ||
{ | ||
await new ValueTask(this, _valueTaskSource.Version) | ||
.ConfigureAwait(false); | ||
} | ||
finally | ||
{ | ||
#if NET6_0_OR_GREATER | ||
await tokenRegistration.DisposeAsync() | ||
.ConfigureAwait(false); | ||
#else | ||
tokenRegistration.Dispose(); | ||
#endif | ||
} | ||
} | ||
|
||
public void Set() | ||
{ | ||
if (IsSet) | ||
{ | ||
return; | ||
} | ||
|
||
Volatile.Write(ref _isSet, true); | ||
_valueTaskSource.SetResult(true); | ||
} | ||
|
||
public void Reset() | ||
{ | ||
if (!IsSet) | ||
{ | ||
return; | ||
} | ||
|
||
Volatile.Write(ref _isSet, false); | ||
_valueTaskSource.Reset(); | ||
} | ||
|
||
void IValueTaskSource.GetResult(short token) | ||
{ | ||
if (token != _valueTaskSource.Version) | ||
{ | ||
ThrowIncorrectTokenException(); | ||
} | ||
|
||
_valueTaskSource.GetResult(token); | ||
} | ||
|
||
ValueTaskSourceStatus IValueTaskSource.GetStatus(short token) | ||
{ | ||
if (token != _valueTaskSource.Version) | ||
{ | ||
ThrowIncorrectTokenException(); | ||
} | ||
|
||
return _valueTaskSource.GetStatus(token); | ||
} | ||
|
||
void IValueTaskSource.OnCompleted(Action<object?> continuation, object? state, short token, ValueTaskSourceOnCompletedFlags flags) | ||
{ | ||
if (token != _valueTaskSource.Version) | ||
{ | ||
ThrowIncorrectTokenException(); | ||
} | ||
|
||
_valueTaskSource.OnCompleted(continuation, state, token, flags); | ||
} | ||
|
||
[DoesNotReturn] | ||
static void ThrowIncorrectTokenException() => | ||
throw new InvalidOperationException("ValueTask cannot be awaited multiple times."); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.