Fix handling when rate limit lease can't be acquired. #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
changed the title
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1793
branch
2 times, most recently
from
c7d40c3 to
4271e64
Compare
* Expand throttling delay code, add comment. * Add `ThrowsExceptionRateLimiter` and use it in `MaybeSomethingUpWithRateLimiter_GH1793`, which reproduces the issue. * Reproduce issue by artifically never acquiring rate limiter leases. * Fix issue by catching `SemaphoreFullException` and checking that the exception was thrown in a valid failure case.
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1793
branch
from
4271e64 to
068bc00
Compare
|
Reviewed with @Gsantomaggio over Zoom 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1793
Also refactor the throttling delay code to be a bit easier to read/understand.