noAck -> autoAck #297
Merged
noAck -> autoAck #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Dec 9, 2016
michaelklishin
requested changes
Dec 9, 2016
There was a problem hiding this comment.
Building from scratch fails with
/Users/antares/Development/RabbitMQ/umbrella.git/deps/rabbitmq_dotnet_client/gensrc/autogenerated-api-0-9-1.cs(3841,13): error CS1061: 'BasicConsume' does not contain a definition for 'm_autoAck' and no extension method 'm_autoAck' accepting a first argument of type 'BasicConsume' could be found (are you missing a using directive or an assembly reference?)
/Users/antares/Development/RabbitMQ/umbrella.git/deps/rabbitmq_dotnet_client/gensrc/autogenerated-api-0-9-1.cs(3853,13): error CS1061: 'BasicGet' does not contain a definition for 'm_autoAck' and no extension method 'm_autoAck' accepting a first argument of type 'BasicGet' could be found (are you missing a using directive or an assembly reference?)
so looks like Apigen needs updating, too (and possibly special casing for this one attribute).
|
@michaelklishin I'll fix that. Must have forgotten to re-run autogen. |
michaelklishin
approved these changes
Dec 9, 2016
GitHubPang
added a commit
to GitHubPang/rabbitmq-website
that referenced
this pull request
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
This renames the
noAckparameter toautoAck.Before we release this change we need to update
rabbitmq-websiteandrabbitmq-tutorialswith the new name.