Skip to content

Remove deprecated IConnection.AutoClose #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Remove deprecated IConnection.AutoClose #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions projects/client/RabbitMQ.Client/src/client/api/IConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,6 @@ namespace RabbitMQ.Client
/// </remarks>
public interface IConnection : NetworkConnection, IDisposable
{
/// <summary>
/// If true, will close the whole connection as soon as there are no channels open on it;
/// if false, manual connection closure will be required.
/// </summary>
/// <remarks>
/// DON'T set AutoClose to true before opening the first
/// channel, because the connection will be immediately closed if you do!
/// </remarks>
[Obsolete("Please explicitly close connections instead.")]
bool AutoClose { get; set; }

/// <summary>
/// The maximum channel number this connection supports (0 if unlimited).
/// Usable channel numbers range from 1 to this number, inclusive.
Expand Down
7 changes: 0 additions & 7 deletions projects/client/RabbitMQ.Client/src/client/impl/AutorecoveringConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,13 +288,6 @@ public event EventHandler<EventArgs> Recovery

public string ClientProvidedName { get; private set; }

[Obsolete("Please explicitly close connections instead.")]
public bool AutoClose
{
get { return m_delegate.AutoClose; }
set { m_delegate.AutoClose = value; }
}

public ushort ChannelMax
{
get { return m_delegate.ChannelMax; }
Expand Down
7 changes: 0 additions & 7 deletions projects/client/RabbitMQ.Client/src/client/impl/Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,6 @@ public event EventHandler<ConnectionRecoveryErrorEventArgs> ConnectionRecoveryEr
}
public string ClientProvidedName { get; private set; }

[Obsolete("Please explicitly close connections instead.")]
public bool AutoClose
{
get { return m_sessionManager.AutoClose; }
set { m_sessionManager.AutoClose = value; }
}

public ushort ChannelMax
{
get { return m_sessionManager.ChannelMax; }
Expand Down