Make IAsyncConnectionFactory public

[paulomorgado]

Proposed Changes

While the API for creating asynchronous connections is not the best approach, it is what we have and it's impossible to rely on interfaces only to create asynchronous connections.

This would be immediately solved if IAsyncConnectionFactory was public.

Fixes #482

Types of Changes

• Bugfix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (correction or otherwise)
• Cosmetics (whitespace, appearance)

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

I don't think this would be a breaking change for the next minor version.

[kjnilsson]

This looks fine with me - any other comments on this?

One think I would say is that we could improve the async api for 6.0 quite happily.

[paulomorgado]

We should, definitely, improve async on 6.0.

Will this be available in 5.2?

[michaelklishin]

It's not clear if there is going to be a 5.2.0 and when. Too many changes in master are breaking and all focus seems to be on 6.0.