Skip to content

Add additional headers #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Add additional headers #667

merged 2 commits into from
Dec 3, 2019

Conversation

sergeyshaykhullin
Copy link
Contributor

@sergeyshaykhullin sergeyshaykhullin commented Dec 2, 2019

Add XQueueMode, XQueueType, XQuorumInitialGroupSize, XSingleActiveConsumer and XOverflow header constants

Proposed Changes

I used a lot my own headers class, but discovered that you have one. I added some missed headers

Links to check headers:

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

  • Should i add this constants to APIApproval.Approve.approved.txt file?
  • I'm not sure I wrote the comments correctly

sergeyshaykhullin and others added 2 commits December 3, 2019 00:41
Add XQueueMode, XQueueType, XQuorumInitialGroupSize, XSingleActiveConsumer and XOverflow header constants
@michaelklishin michaelklishin merged commit 0c45012 into rabbitmq:master Dec 3, 2019
@michaelklishin
Copy link
Contributor

Thank you!

@michaelklishin
Copy link
Contributor

@lukebakken @kjnilsson I assume this can be backported to 5.x?

@lukebakken lukebakken added this to the 5.2.0 milestone Feb 11, 2020
@lukebakken lukebakken self-assigned this Feb 11, 2020
lukebakken pushed a commit that referenced this pull request Feb 11, 2020
Add additional headers

(cherry picked from commit 0c45012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants