Skip to content

Updating Framework Targets #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

stebet
Copy link
Contributor

@stebet stebet commented Jan 17, 2020

Proposed Changes

This is the first PR to satisfy #686. Redundant package imports and code removed as well as ifdefs that are redundant as a result. All tests run successfully.

Types of Changes

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

This is a breaking change as it changes the supported target frameworks.

@michaelklishin michaelklishin merged commit 6b14316 into rabbitmq:master Jan 17, 2020
@stebet stebet deleted the frameworkTargets branch January 17, 2020 17:39
@bording bording mentioned this pull request Jan 18, 2020
@lukebakken lukebakken added this to the 6.0.0 milestone Jan 21, 2020
@lukebakken lukebakken self-assigned this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants