Skip to content

Allocation improvements #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

Anarh2404
Copy link
Contributor

Proposed Changes

Ported some changes from the #734
Made ContantHeader and Method readers/writers structs

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Before
before
After
after

@michaelklishin
Copy link
Contributor

@Anarh2404 thank you. Now that #732 is in, are we expected to merge this PR next or there can be some overlap/competition with #706? We really could use some guidance as while all these allocation improvement PRs are appreciated, they tend to compete and not collaborate. We would really appreciate a single unified effort from you and @stebet instead of competing PRs.

@Anarh2404
Copy link
Contributor Author

@michaelklishin this PR complements #732 and does not compete with #706

@michaelklishin
Copy link
Contributor

Great, thanks for clarifying.

@stebet
Copy link
Contributor

stebet commented Mar 9, 2020

Looks good to me :)

@michaelklishin michaelklishin merged commit f5318de into rabbitmq:master Mar 9, 2020
@lukebakken lukebakken mentioned this pull request Mar 9, 2020
@lukebakken lukebakken added this to the 6.0.0 milestone Mar 9, 2020
@lukebakken lukebakken self-assigned this Mar 9, 2020
@Anarh2404 Anarh2404 deleted the improvements branch March 9, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants