Schedule instead of GetAwaiter().GetResult() #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be green once rebased on top of #772 |
danielmarbach
force-pushed
the
model-shutdown
branch
from
5b7cbee to
598dcc1
Compare
lukebakken
force-pushed
the
model-shutdown
branch
from
598dcc1 to
958c876
Compare
lukebakken
approved these changes
Mar 25, 2020
|
Can you verify if my assumptions where correct? Based on my research the work pool should still be available and therefore we can schedule still but I would like to have this confirmed |
lukebakken
added a commit
that referenced
this pull request
Mar 25, 2020
Schedule instead of GetAwaiter().GetResult() (cherry picked from commit c0178a2)
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Any reasons why we can't directly use Schedule instead of
GetAwaiter().GetResul()?