Fix AsyncConsumerWorkService #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
michaelklishin
approved these changes
Mar 24, 2020
|
Thank you! |
lukebakken
reviewed
Mar 24, 2020
| @@ -45,7 +45,7 @@ class WorkPool | |||
| readonly ModelBase _model; | |||
| CancellationTokenRegistration _tokenRegistration; | |||
| volatile TaskCompletionSource<bool> _syncSource = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously); | |||
| private Task _task; | |||
| private Task _worker; | |||
There was a problem hiding this comment.
@danielmarbach _worker is not really used anywhere, though. What does keeping it in an instance variable accomplish?
There was a problem hiding this comment.
Nothing until we reimplement the graceful shutdown as discussed in your PR
lukebakken
pushed a commit
that referenced
this pull request
Mar 25, 2020
Fix AsyncConsumerWorkService (cherry picked from commit a11303e)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Split out of #772 that only contains async changes