Skip to content

Misc cleanup #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 26, 2020
Merged

Misc cleanup #780

merged 11 commits into from
Mar 26, 2020

Conversation

bording
Copy link
Collaborator

@bording bording commented Mar 25, 2020

Proposed Changes

This is primarily just cleaning up project files and removing some things that as far as I can tell are leftover bits from an older era.

The only real change of impact to the code is related to switching to the standard defines. Turns out the one in TcpClientAdapter wasn't needed any more since net461 supports ConnectAsync.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit 8aed00f into rabbitmq:master Mar 26, 2020
@michaelklishin
Copy link
Contributor

Thank you!

@bording bording deleted the misc-cleanup branch March 26, 2020 13:53
@lukebakken lukebakken self-assigned this Mar 26, 2020
@lukebakken lukebakken added this to the 6.0.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants