Skip to content

Package updates #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Package updates #796

merged 2 commits into from
Mar 31, 2020

Conversation

lukebakken
Copy link
Collaborator

No description provided.

@lukebakken lukebakken added this to the 6.0.0 milestone Mar 30, 2020
@lukebakken
Copy link
Collaborator Author

@bording thanks! I tried upgrading System.Memory via Visual Studio and it wanted to bring in other packages (I forget which) but that doesn't seem to be the case here.

@bording
Copy link
Collaborator

bording commented Mar 30, 2020

@lukebakken I was confused for a second when I didn't get a prompt to create a new PR, but I see that you have already! 😄

I pushed the branch up and then noticed a problem. You know how I was saying it could be risky to bring in packages like System.Memory when using "old" .NET Framework versions? Turns out we were hitting a problem and the new package revealed it.

The older System.Memory package was causing the net461 target to be referencing the wrong System.Net.Sockets assembly, It was referencing a newer version that isn't actually part of .NET Framework 4.6.1 but will be on the system if a newer version of .NET Framework is installed.

That was giving the code access to a ConnectAsync overload that it shouldn't have had available, so I had to reintroduce the #ifdef around it.

@lukebakken
Copy link
Collaborator Author

lukebakken commented Mar 30, 2020

@bording you just answered the question I was about to ask ... which was "how in the heck did these changes expose that build failure???"

At least the AppVeyor build revealed that error.

@lukebakken lukebakken marked this pull request as ready for review March 31, 2020 00:01
@lukebakken lukebakken merged commit f540a8f into master Mar 31, 2020
@lukebakken lukebakken deleted the package-updates branch March 31, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants