Skip to content

Backport #865 to 6.x #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2020
Merged

Backport #865 to 6.x #892

merged 1 commit into from
Jul 6, 2020

Conversation

michaelklishin
Copy link
Contributor

This is #865 backported to 6.x.

@danielmarbach
Copy link
Collaborator

BTW is master already on the v7 major? If yes I could send a PR that breaks the interface and removes the obsolete again

@lukebakken
Copy link
Collaborator

lukebakken commented Jul 6, 2020 •
edited
Loading

@danielmarbach yes master will be version 7.0.0. We are taking commits to master that are 6.X compatible and cherry-picking them to the 6.x branch. Usually the merge commit created by GH when a PR is merged is what is backported.

@lukebakken lukebakken added this to the 6.2.0 milestone Jul 6, 2020
@lukebakken lukebakken self-assigned this Jul 6, 2020
@lukebakken lukebakken merged commit 1e45950 into 6.x Jul 6, 2020
@lukebakken lukebakken deleted the backport-pr-865 branch July 6, 2020 17:18
@lukebakken
Copy link
Collaborator

Thanks everyone! I will produce a 6.2 RC today.

@michaelklishin
Copy link
Contributor Author

@danielmarbach by all means do. Thank you.

@danielmarbach danielmarbach mentioned this pull request Jul 7, 2020
Merged
11 tasks
@danielmarbach
Copy link
Collaborator

Here we go #895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmarbach danielmarbach danielmarbach approved these changes

@bording bording Awaiting requested review from bording

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelklishin @danielmarbach @lukebakken