This repository was archived by the owner on Nov 18, 2020. It is now read-only.
Respect caller-provided durability property #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
priviterag
changed the title
priviterag
force-pushed
the
rabbitmq-stomp-24
branch
from
fe5d699 to
602b5e8
Compare
priviterag
changed the title
|
@michaelklishin this can be merged now |
priviterag
changed the title
|
@priviterag this is now ready for QA but the title still says |
michaelklishin
changed the title
dumbbell
added a commit
to rabbitmq/rabbitmq-amqp1.0
that referenced
this pull request
Dec 11, 2015
Since rabbitmq/rabbitmq-erlang-client#16, the `durable` parameter is honored (instead of being forced to true). So AMQP 1.0 queues are created as non-durable. In our Erlang AMQP client, this means the queue is created with auto-delete and exclusive set to true by default. We must explicitely set those to false. The testsuite is expanded to check that AMQP 0-9-1 queues created out-of-band can be properly used from AMQP 1.0, no matter their parameters. Fixes #22.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of rabbitmq/rabbitmq-stomp#24.