Skip to content

Support dynamic versioning #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dumbbell opened this issue Jan 14, 2016 · 3 comments
Closed

Support dynamic versioning #123

dumbbell opened this issue Jan 14, 2016 · 3 comments

Comments

@dumbbell
Copy link
Contributor

With the move to Maven (#37), the client version number is now hard-coded in pom.xml. We need a way to make this number dynamic so we can supply it from the environment or on the command line.

@dumbbell dumbbell added this to the 3.7.0 milestone Jan 14, 2016
@dumbbell
Copy link
Contributor Author

Here is an article (and three articles linked inside), pointed out by @michaelklishin, which could help:
https://axelfontaine.com/blog/final-nail.html

@michaelklishin
Copy link
Contributor

I believe this can be closed in favour of managing the version with Maven. Now that the master of this client is no longer tied to RabbitMQ server releases, we can rely on that. @dumbbell @acogoluegnes WDYT?

@acogoluegnes
Copy link
Contributor

@dumbbell @michaelklishin LGTM

stream-iori pushed a commit to stream-iori/rabbitmq-java-client that referenced this issue Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants