Skip to content

Provide factories to create NIO artefacts #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acogoluegnes opened this issue Sep 27, 2018 · 0 comments
Closed

Provide factories to create NIO artefacts #410

acogoluegnes opened this issue Sep 27, 2018 · 0 comments
Assignees
@acogoluegnes
Labels
effort-low enhancement
Milestone
4.9.0

Comments

@acogoluegnes
Copy link
Contributor

acogoluegnes commented Sep 27, 2018 •
edited
Loading

Namely ByteBuffers, BlockingQueue, and why not lambda to enqueue and dequeue frames. This would allow to experiment with different strategies, like direct ByteBuffers or other blocking queue implementations.
@acogoluegnes acogoluegnes added this to the 5.5.0 milestone Sep 27, 2018
@acogoluegnes acogoluegnes self-assigned this Sep 27, 2018
acogoluegnes added a commit that referenced this issue Oct 12, 2018
@acogoluegnes
Add ByteBufferFactory for NIO mode
bb2c47a 
This allows to create heap-based or direct ByteBuffer instances.

References #410
acogoluegnes added a commit that referenced this issue Oct 12, 2018
@acogoluegnes
Add abstraction to create NIO frame queue
8c9577d 
Allows to use other data structure implementations than JDK's
ArrayBlockingQueue and BlockingQueue.

References #410
@acogoluegnes acogoluegnes mentioned this issue Oct 12, 2018
Merged
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Remove wildcard for NIO write queue factory
a9fa759 
No necessary here.

References #410
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Add ByteBufferFactory for NIO mode
0252e2c 
This allows to create heap-based or direct ByteBuffer instances.

References #410

(cherry picked from commit bb2c47a)
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Add abstraction to create NIO frame queue
5e0c25a 
Allows to use other data structure implementations than JDK's
ArrayBlockingQueue and BlockingQueue.

References #410

(cherry picked from commit 8c9577d)
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Remove wildcard for NIO write queue factory
2590705 
No necessary here.

References #410

(cherry picked from commit a9fa759)
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Add ByteBufferFactory for NIO mode
6de69db 
This allows to create heap-based or direct ByteBuffer instances.

References #410

(cherry picked from commit bb2c47a)
(cherry picked from commit 0252e2c)
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Add abstraction to create NIO frame queue
6ff2da5 
Allows to use other data structure implementations than JDK's
ArrayBlockingQueue and BlockingQueue.

References #410

(cherry picked from commit 8c9577d)
(cherry picked from commit 5e0c25a)

Conflicts:
	src/main/java/com/rabbitmq/client/impl/nio/NioParams.java
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Remove wildcard for NIO write queue factory
2ab256e 
No necessary here.

References #410

(cherry picked from commit a9fa759)
(cherry picked from commit 2590705)
acogoluegnes added a commit that referenced this issue Oct 15, 2018
@acogoluegnes
Refactor NIO factories to Java 6
7579bf8 
References #410
@acogoluegnes acogoluegnes modified the milestones: 5.5.0, 4.9.0 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
effort-low enhancement
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
1 participant
@acogoluegnes