Skip to content

remove e2e bindings for auto-delete exchanges #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2017
Merged

remove e2e bindings for auto-delete exchanges #281

merged 1 commit into from
May 26, 2017

Conversation

vikinghawk
Copy link
Contributor

@vikinghawk vikinghawk commented May 26, 2017

It was possible to have abandoned e2e bindings in the recordedBindings. This caused a channel error during recovery and caused remaining recovery items to fail as well.

Workflow to reproduce:

  1. create durable topic exchange -> auto-delete headers exchange -> auto-delete queue -> consumer
  2. cancel consumer
  3. calls maybeDeleteRecordedAutoDeleteQueue which ends up deleting the recorded queue
  4. calls maybeDeleteRecordedAutoDeleteExchange and removes the recorded headers exchange

In that case the e2e binding from the durable topic exchange to the now deleted headers exchange still existed. Calling deleteRecordedExchange() method instead will then clean up the bindings for the exchange.

@michaelklishin michaelklishin merged commit e309568 into rabbitmq:4.1.x-stable May 26, 2017
@michaelklishin
Copy link
Contributor

Thank you!

@michaelklishin michaelklishin added this to the 4.1.1 milestone May 26, 2017
@vikinghawk vikinghawk deleted the e2e_binding_recovery_fix branch May 26, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants