Add RpcClient doCall/responseCall/primitiveCall overloads which include timeout #338
Conversation
…de timeout There will be use cases where a single shared timeout specified in the constructor of the RpcClient will not match up with the expected timeout for different rpc calls made using the rpc client. It's then convenient to be able to specifiy the timeout value on a per method call basis. Otherwise the user of RpcClient would have to create multiple instances of RpcClient, incurring the startup cost and having redundant consumers of the response queue.
|
@AndreasPresthammer Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@acogoluegnes this looks like a reasonable addition to me, even though we use |
|
@michaelklishin LGTM. @AndreasPresthammer Could you please sign the contributor licence agreement? |
|
Have to check with legal at my employer. Hopefully shouldn't take too long. |
|
@AndreasPresthammer Any news on the CA signature? |
|
@AndreasPresthammer Thank you for signing the Contributor License Agreement! |
|
I've signed the CLA. |
|
@acogoluegnes looks like we can back port this all the way to |
|
@michaelklishin Yes, looks good. |
|
@michaelklishin But only in |
|
Cherry-picked on |
Proposed Changes
There will be use cases where a single shared timeout specified in the constructor
of the RpcClient will not match up with the expected timeout for different rpc calls
made using the rpc client. It's then convenient to be able to specifiy the timeout value
on a per method call basis. Otherwise the user of RpcClient would have to create
multiple instances of RpcClient, incurring the startup cost and having redundant
consumers of the response queue.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentNote:
Unable to run the tests locally with 'make tests'. Getting this error:
[ERROR] Failed to execute goal org.codehaus.gmaven:groovy-maven-plugin:2.0:execute (query-test-tls-certs-dir) on project amqp-client: Execution query-test-tls-certs-dir of goal org.codehaus.gmaven:groovy-maven-plugin:2.0:execute failed: org.apache.maven.plugin.MojoExecutionException: Failed to query test TLS certs directory with command: make -C /home/andreas/code/rabbitmq-java-client/deps/rabbit --no-print-directory show-test-tls-certs-dir DEPS_DIR=/home/andreas/code/rabbitmq-java-client/deps -> [Help 1]