Stops Recovery When Client Closes #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a boolean flag, manuallyClosed to keep track of whether or not the AutoRecoveringConnection has been told to close by the application. If flag is set before recovery attempt, autorecovery fails out. If flag is set mid recovery attempt, creates the new connection, then immediately aborts it.
|
Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a boolean flag, manuallyClosed to keep track of whether or not the
AutoRecoveringConnection has been told to close by the application.
If flag is set before recovery attempt, autorecovery fails out.
If flag is set mid recovery attempt, creates the new
connection, then immediately aborts it.
Comments, whitespace match with approved style.
Did not address issue of recoverConnection returning boolean, could not see way to do so without introducing race condition or requiring larger scope of changes.
Did not modify double checked locking in recoverConnection, am not sure of policies in this library for what public methods are allowed to block.