This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Display user-provided connection name, if any #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hairyhum we should not completely replace the name we have. For several reasons:
So the user-provided name, when present, should be listed in a separate column (and on the connection page), not replace the name we have. |
michaelklishin
changed the title
To avoid the confusion, don't display client-provided connection name on the first line. To avoid very long page titles, move client-provided connection name into the details section.
brerx
added a commit
to brerx/bunny
that referenced
this pull request
Sep 11, 2020
This is shown in the Management UI since rabbitmq/rabbitmq-management#172
brerx
added a commit
to brerx/bunny
that referenced
this pull request
Sep 11, 2020
This is shown in the Management UI since rabbitmq/rabbitmq-management#172
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If client provided client property
connection_name, it will be displayed in management GUI.Part of rabbitmq/rabbitmq-server#104.