This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Fix backwards sort arrow icon. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's conventional in GUIs to use a triangle or arrow icon to indicate how data is currently sorted in a column - where the wide part of the triangle being at the top and the narrow part at the bottom indicates that larger rows are above (decreasing sort), and vice versa. In other words, the direction in which the icon width increases reflects the direction in which the values in the column increase.
|
@serhalp good catch, thank you! |
michaelklishin
added a commit
that referenced
this pull request
Nov 27, 2015
Fix backwards sort arrow icon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's conventional in GUIs to use a triangle or arrow icon to indicate how data is currently sorted in a column – where the wide part of the triangle being at the top and the narrow part at the bottom indicates that larger rows are above (decreasing sort), and vice versa. In other words, the direction in which the icon width increases reflects the direction in which the values in the column increase.
The current icon is contrary to most UIs out there, which can be misleading – and it just feels plain wrong:
This PR swaps the two icons.