Skip to content

Commit 4b87ded

Browse files
author
Loïc Hoguin
committed
Remove pointless todos
The first is not going to be super useful. The second is not possible because we already have a check on the file_summary table.
1 parent 12a63a4 commit 4b87ded

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

deps/rabbit/src/rabbit_msg_store.erl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,6 @@ init([VHost, Type, BaseDir, ClientRefs, StartupFunState]) ->
744744
{ok, CurOffset} = file_handle_cache:position(CurHdl, CurOffset),
745745
ok = file_handle_cache:truncate(CurHdl),
746746

747-
%% @todo Do we want to maybe_gc on init by checking all files?
748747
{ok, State1 #msstate { current_file_handle = CurHdl,
749748
current_file_offset = CurOffset },
750749
hibernate,
@@ -1807,8 +1806,6 @@ truncate_file(File, Size, ThresholdTimestamp, #gc_state{ file_summary_ets = File
18071806
[File]),
18081807
defer;
18091808
_ ->
1810-
%% @todo Should probably make sure the file still exists before we try to truncate.
1811-
%% The file may have been deleted in the meantime (fully acked during compact, delete scheduled, then executed, then truncate scheduled).
18121809
FileName = filenum_to_name(File),
18131810
{ok, Fd} = file:open(form_filename(Dir, FileName), [read, write, binary, raw]),
18141811
{ok, _} = file:position(Fd, Size),

0 commit comments

Comments
 (0)