Merge pull request #10375 from rabbitmq/catch-ets-exception-on-startup

Catch ETS exception when system is still starting

Author: michaelklishin

deps/rabbitmq_stream/src/rabbit_stream.erl

@@ -87,15 +87,19 @@ port() ->
     end.
 
 port_from_listener() ->
-    Listeners = rabbit_networking:node_listeners(node()),
-    Port =
+    try
+        Listeners = rabbit_networking:node_listeners(node()),
         lists:foldl(fun (#listener{port = Port, protocol = stream}, _Acc) ->
                             Port;
                         (_, Acc) ->
                             Acc
                     end,
-                    undefined, Listeners),
-    Port.
+                    undefined, Listeners)
+    catch error:Reason ->
+              %% can happen if a remote node calls and the current has not fully started yet
+              rabbit_log:info("Error while retrieving stream plugin port: ~tp", [Reason]),
+              {error, Reason}
+    end.
 
 tls_port() ->
     case application:get_env(rabbitmq_stream, advertised_tls_port,
@@ -108,16 +112,20 @@ tls_port() ->
     end.
 
 tls_port_from_listener() ->
-    Listeners = rabbit_networking:node_listeners(node()),
-    Port =
+    try
+        Listeners = rabbit_networking:node_listeners(node()),
         lists:foldl(fun (#listener{port = Port, protocol = 'stream/ssl'},
                          _Acc) ->
                             Port;
                         (_, Acc) ->
                             Acc
                     end,
-                    undefined, Listeners),
-    Port.
+                    undefined, Listeners)
+        catch error:Reason ->
+        %% can happen if a remote node calls and the current has not fully started yet
+        rabbit_log:info("Error while retrieving stream plugin port: ~tp", [Reason]),
+        {error, Reason}
+    end.
 
 stop(_State) ->
     ok.