Catch ETS exception when system is still starting #10375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the ETS table may be not created yet. A stream connection can call another node to get the port of the stream plugin on this node. The stream plugin uses the rabbit_networking module, which relies on an ETS table to store listener information. The table may be not created yet when the node starts up, so the calling node ends up logging a large stack trace. This commit catches the exception and logs a simple message. This reduces unnecessary noise in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the ETS table may be not created yet.
A stream connection can call another node to
get the port of the stream plugin on this node.
The stream plugin uses the rabbit_networking module, which relies on an ETS table to store listener information. The table may be not created yet when the node starts up, so the calling node ends up logging a large stack trace.
This commit catches the exception and logs a simple message. This reduces unnecessary noise in the logs.